refactor: code quality improvements (P3)
## Type Safety
- Add zod runtime validation for external API responses
* Namecheap API responses (domain-register.ts)
* n8n webhook responses (n8n-service.ts)
* User request bodies (routes/api.ts)
* Replaced unsafe type assertions with safeParse()
* Proper error handling and logging
## Dead Code Removal
- Remove unused callDepositAgent function (127 lines)
* Legacy Assistants API code no longer needed
* Now using direct code execution
* File reduced from 469 → 345 lines (26.4% reduction)
## Configuration Management
- Extract hardcoded URLs to environment variables
* Added 7 new vars in wrangler.toml:
OPENAI_API_BASE, NAMECHEAP_API_URL, WHOIS_API_URL,
CONTEXT7_API_BASE, BRAVE_API_BASE, WTTR_IN_URL, HOSTING_SITE_URL
* Updated Env interface in types.ts
* All URLs have fallback to current production values
* Enables environment-specific configuration (dev/staging/prod)
## Dependencies
- Add zod 4.3.5 for runtime type validation
## Files Modified
- Configuration: wrangler.toml, types.ts, package.json
- Services: 11 TypeScript files with URL/validation updates
- Total: 15 files, +196/-189 lines
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
// Weather Tool - wttr.in integration
|
||||
import type { Env } from '../types';
|
||||
|
||||
export const weatherTool = {
|
||||
type: 'function',
|
||||
@@ -18,11 +19,12 @@ export const weatherTool = {
|
||||
},
|
||||
};
|
||||
|
||||
export async function executeWeather(args: { city: string }): Promise<string> {
|
||||
export async function executeWeather(args: { city: string }, env?: Env): Promise<string> {
|
||||
const city = args.city || 'Seoul';
|
||||
try {
|
||||
const wttrUrl = env?.WTTR_IN_URL || 'https://wttr.in';
|
||||
const response = await fetch(
|
||||
`https://wttr.in/${encodeURIComponent(city)}?format=j1`
|
||||
`${wttrUrl}/${encodeURIComponent(city)}?format=j1`
|
||||
);
|
||||
const data = await response.json() as any;
|
||||
const current = data.current_condition[0];
|
||||
|
||||
Reference in New Issue
Block a user